Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ws: BadResource on socket.close() #9879

Closed
timonson opened this issue Mar 24, 2021 · 0 comments · Fixed by #9755
Closed

ws: BadResource on socket.close() #9879

timonson opened this issue Mar 24, 2021 · 0 comments · Fixed by #9755
Labels
bug Something isn't working correctly ext/websocket related to the ext/websocket crate

Comments

@timonson
Copy link
Contributor

Since deno version 1.8.0, invoking socket.close() on the client side will cause a BadResource error:

error: Uncaught (in promise) BadResource: Bad resource ID
at handleError (deno:core/core.js:186:12)
at jsonOpParseResult (deno:core/core.js:356:9)
at opSync (deno:core/core.js:259:32)
at jsonOpSync (deno:core/core.js:372:12)
at Object.close (deno:core/core.js:383:12)
at WebSocket.#eventLoop (deno:op_crates/websocket/01_websocket.js:353:18)

It should be easy to reproduce this error but let me know if you need more information please.
@lucacasonato lucacasonato transferred this issue from denoland/deno_std Mar 24, 2021
@lucacasonato lucacasonato mentioned this issue Mar 24, 2021
Merged
@lucacasonato lucacasonato added bug Something isn't working correctly cli related to cli/ dir ext/websocket related to the ext/websocket crate and removed cli related to cli/ dir labels Mar 24, 2021
@timonson timonson mentioned this issue Mar 27, 2021
Closed
@aricart aricart mentioned this issue Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly ext/websocket related to the ext/websocket crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(websocket): ignore resource close error lucacasonato/deno
2 participants
@lucacasonato @timonson