fix(websocket): ignore resource close error #9755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Mar 12, 2021
|
Possibly - this is an internal Deno error we are exposing to the user though. No web API should ever through a |
bartlomieju
reviewed
Mar 15, 2021
bartlomieju
approved these changes
Mar 24, 2021
|
This PR should probably be landed onto |
|
I'm going to pull the check into a helper function. Then yeah - let's cherry-pick it for 1.8.3 |
It is possible that the WebSocket is already closed when we try to close it with `WebSocket#close` or in the `error` or `close` events. Currently this leads to an uncatchable promise rejection. This changes this so that closing an already closed WebSocket is a noop.
lucacasonato
force-pushed
the
ignore_already_closed_websocket_error
branch
from
211bb66
to
933e399
Compare
Making it a noop is a good idea, the websocket event gets called after |
lucacasonato
added a commit
that referenced
this pull request
Apr 1, 2021
It is possible that the WebSocket is already closed when we try to close it with `WebSocket#close` or in the `error` or `close` events. Currently this leads to an uncatchable promise rejection. This changes this so that closing an already closed WebSocket is a noop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the WebSocket is already closed when we try to
close it with
WebSocket#closeor in theerrororcloseevents.Currently this leads to an uncatchable promise rejection. This changes
this so that closing an already closed WebSocket is a noop.
Closes #9879
Closes #9958