Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli/flags): reorganize declarations #10204

Merged
merged 3 commits into from Apr 16, 2021

Conversation

crowlKats
Copy link
Member

Reorganizes subcommand & arg declarations & corresponding parse functions as they currently are all over the place. Order is subcommands alphabetically > args > parse. Parse functions are in the same order as subcommands & args.
Vastly simplifies working on (and in future, reviewing) #8617

@ry
Copy link
Member

ry commented Apr 16, 2021

This is conflicting a bit with #10186 but... I'll land this one first and redo mine since yours is already green.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit d8447cf into denoland:main Apr 16, 2021
@crowlKats crowlKats deleted the reorganize_flags branch April 17, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants