Web API: URLSearchParams #1049
Merged
Web API: URLSearchParams #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ry
reviewed
Oct 21, 2018
BUILD.gn
Outdated
| @@ -107,6 +107,7 @@ ts_sources = [ | |||
| "js/trace.ts", | |||
| "js/truncate.ts", | |||
| "js/types.ts", | |||
| "js/urlsearchparams.ts", | |||
ry
reviewed
Oct 21, 2018
js/urlsearchparams_test.ts
Outdated
| // Copyright 2018 the Deno authors. All rights reserved. MIT license. | ||
| import { test, assert, assertEqual } from "./test_util.ts"; | ||
|
|
||
| test(function initString() { |
There was a problem hiding this comment.
Can you prefix call of the test function names with “url” or “urlSearchParams”
This is so we can easily filter
There was a problem hiding this comment.
Yes, fixed in next commit 👍
ztplz
approved these changes
Oct 21, 2018
js/urlsearchparams.ts
Outdated
|
|
||
| private params: [string, string][] = []; | ||
|
|
||
| public constructor(init: string | Iterable<[string, string]> | Record<string, string> = '') { |
There was a problem hiding this comment.
init may be undefined
var u = new URLSearchParams()
undefined
u instanceof URLSearchParams
true
There was a problem hiding this comment.
The = at the end states it's optional. It defaults to '' to comply with WHATWG.
js/urlsearchparams.ts
Outdated
| * searchParams.append('name', 'first'); | ||
| * searchParams.append('name', 'second'); | ||
| */ | ||
| public append(name: string, value: string): void { |
There was a problem hiding this comment.
Fixed this and all other occurrences in the next commit, thanks you 👍
js/urlsearchparams.ts
Outdated
| * | ||
| * searchParams.delete('name'); | ||
| */ | ||
| public delete(name: string): void { |
js/urlsearchparams.ts
Outdated
| * | ||
| * searchParams.getAll('name'); | ||
| */ | ||
| public getAll(name: string): string[] { |
js/urlsearchparams.ts
Outdated
| * | ||
| * searchParams.get('name'); | ||
| */ | ||
| public get(name: string): string | null { |
js/urlsearchparams.ts
Outdated
| * | ||
| * for (const key of searchParams.keys()) console.log(key); | ||
| */ | ||
| public *keys(): Iterable<string> { |
js/urlsearchparams.ts
Outdated
| * | ||
| * for (const value of searchParams.values()) console.log(value); | ||
| */ | ||
| public *values(): Iterable<string> { |
js/urlsearchparams.ts
Outdated
| * | ||
| * for (const [key, value] of searchParams.entries()) console.log(key, value); | ||
| */ | ||
| public *entries(): Iterable<[string, string]> { |
js/urlsearchparams.ts
Outdated
| * | ||
| * for (const [key, value] of searchParams) console.log(key, value); | ||
| */ | ||
| public *[Symbol.iterator](): Iterable<[string, string]> { |
js/urlsearchparams.ts
Outdated
| * | ||
| * searchParams.toString(); | ||
| */ | ||
| public toString(): string { |
7 tasks
acconrad
reviewed
Oct 22, 2018
| export class URLSearchParams { | ||
| private params: Array<[string, string]> = []; | ||
|
|
||
| constructor(init: string | string[][] | Record<string, string> = "") { |
There was a problem hiding this comment.
If this spec lists this as optional shouldn't this be init?:
| export class URLSearchParams { | ||
| private params: Array<[string, string]> = []; | ||
|
|
||
| constructor(init: string | string[][] | Record<string, string> = "") { |
There was a problem hiding this comment.
If this spec lists this as optional shouldn't this be init?:
acconrad
reviewed
Oct 22, 2018
| export class URLSearchParams { | ||
| private params: Array<[string, string]> = []; | ||
|
|
||
| constructor(init: string | string[][] | Record<string, string> = "") { |
There was a problem hiding this comment.
If this spec lists this as optional shouldn't this be init?:
| export class URLSearchParams { | ||
| private params: Array<[string, string]> = []; | ||
|
|
||
| constructor(init: string | string[][] | Record<string, string> = "") { |
There was a problem hiding this comment.
If this spec lists this as optional shouldn't this be init?:
acconrad
reviewed
Oct 22, 2018
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 27, 2018
- Add URLSearchParams (denoland#1049) - Implement clone for FetchResponse (denoland#1054) - Use content-type headers when importing from URLs. (denoland#1020) - Use checkJs option, JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno (denoland#1068) - Add separate http/https cache dirs to DENO_DIR (denoland#971) - Support https in fetch. (denoland#1100) - Add chmod/chmodSync on unix (denoland#1088) - Remove broken features: --deps and trace() (denoland#1103) - Ergonomics: Prompt TTY for permission escalation (denoland#1081)
Merged
ry
added a commit
that referenced
this pull request
Oct 27, 2018
- Add URLSearchParams (#1049) - Implement clone for FetchResponse (#1054) - Use content-type headers when importing from URLs. (#1020) - Use checkJs option, JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno (#1068) - Add separate http/https cache dirs to DENO_DIR (#971) - Support https in fetch. (#1100) - Add chmod/chmodSync on unix (#1088) - Remove broken features: --deps and trace() (#1103) - Ergonomics: Prompt TTY for permission escalation (#1081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements URLSearchParams with tests. The code has been successfully formatted, linted, and tested.