Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): quick fix actions to ignore lint errors #10627

Merged
merged 4 commits into from Jun 21, 2021
Merged

feat(lsp): quick fix actions to ignore lint errors #10627

merged 4 commits into from Jun 21, 2021

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented May 13, 2021 •
edited

Introduces quick-fix actions to ignore lint errors.

CleanShot.2021-06-16.at.12.13.28.mp4

Closes #10122

@bartlomieju bartlomieju requested a review from kitsonk May 15, 2021 13:34
magurotuna
magurotuna reviewed Jun 8, 2021
View reviewed changes
cli/lsp/analysis.rs Outdated Show resolved Hide resolved
cli/lsp/analysis.rs Outdated Show resolved Hide resolved
@magurotuna magurotuna mentioned this pull request Jun 13, 2021
Closed
@satyarohith satyarohith marked this pull request as ready for review June 16, 2021 08:21
@bartlomieju bartlomieju added this to the 1.12.0 milestone Jun 18, 2021
kitsonk
kitsonk suggested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change that I think we need to make is to add a CodeActionKind of DenoLint since we differ the sources of the lint information as well, so I think we should maintain that separation here.

Otherwise really good, thank you!

@satyarohith satyarohith requested a review from kitsonk June 21, 2021 06:13
kitsonk
kitsonk approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 952caa7 into denoland:main Jun 21, 2021
@satyarohith satyarohith deleted the lint_ignore_code_action branch June 21, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@magurotuna magurotuna magurotuna left review comments

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

lsp: lint diagnostics should have a quick fix to add ignore comment
5 participants
@satyarohith @kitsonk @dsherret @magurotuna @bartlomieju