feat(extensions/crypto): implement subtle.digest #10796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
changed the title
lucacasonato
requested changes
May 30, 2021
caspervonb
changed the title
lucacasonato
reviewed
Jun 2, 2021
bnoordhuis
reviewed
Jun 4, 2021
Comment on lines
+63
to
+65
| const registeredAlgorithms = supportedAlgorithms[op]; | ||
| const algorithmName = Object.keys(registeredAlgorithms) | ||
| .find((key) => key.toLowerCase() == initialAlgorithm.name.toLowerCase()); |
There was a problem hiding this comment.
I'm not thrilled by how roundabout and complicated this approach is. Could simply be:
// Should match op_crypto_subtle_digest() in extensions/crypto/lib.rs
function digestToId(name) {
switch (name) {
case "SHA-1": return 0;
case "SHA-256": return 1;
case "SHA-384": return 2;
case "SHA-512": return 3;
}
throw new DOMException(/* ... */);
}
name = name.toUpperCase();
const id = digestToId(name);
const normalizedAlgorithm = { name };
// etc.There was a problem hiding this comment.
Initial pass was like that, now the whole normalisation thing follows the spec very literally
bnoordhuis
reviewed
Jun 4, 2021
lucacasonato
reviewed
Jun 4, 2021
lucacasonato
reviewed
Jun 4, 2021
lucacasonato
reviewed
Jun 5, 2021
lucacasonato
reviewed
Jun 5, 2021
lucacasonato
reviewed
Jun 5, 2021
|
|
||
| algorithm = webidl.converters.AlgorithmIdentifier(algorithm, { | ||
| context: "Argument 1", | ||
| }); |
There was a problem hiding this comment.
Add prefix argument too: https://github.com/denoland/deno/blob/main/extensions/web/08_text_encoding.js#L158
lucacasonato
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceedes #9069
Co-authored-by: Yacine Hmito yacinehmito@users.noreply.github.com