Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): support the stream option to TextDecoder#decode #10805

Merged
merged 1 commit into from Jun 1, 2021
Merged

feat(web): support the stream option to TextDecoder#decode #10805

merged 1 commit into from Jun 1, 2021

Conversation

andreubotella
Copy link
Contributor

Fixes #5351.

@CLAassistant
Copy link

CLAassistant commented May 31, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

lucacasonato
lucacasonato approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Implementation looks good. Thanks so much :-)

@lucacasonato lucacasonato changed the title fix: Support the stream option to TextDecoder#decode feat(web): support the stream option to TextDecoder#decode May 31, 2021
@lucacasonato lucacasonato merged commit e466a6f into denoland:main Jun 1, 2021
@andreubotella andreubotella deleted the textdecoder-stream-option branch June 1, 2021 09:24
@andreubotella andreubotella mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextDecoder should support the stream option
3 participants
@andreubotella @CLAassistant @lucacasonato