Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): registry auto discovery #10813

Merged
merged 2 commits into from Jun 1, 2021
Merged

feat(lsp): registry auto discovery #10813

merged 2 commits into from Jun 1, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jun 1, 2021 •
edited

Closes: #10194
Fixes: #10468

(this currently includes #10812 which I will rebase once that is merged)

@kitsonk kitsonk mentioned this pull request Jun 1, 2021
Merged
@kitsonk kitsonk marked this pull request as ready for review June 1, 2021 09:26
@kitsonk kitsonk requested a review from lucacasonato June 1, 2021 09:26
lucacasonato
lucacasonato approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried it locally with VSC and works as expected.

@kitsonk kitsonk merged commit bb5bf91 into denoland:main Jun 1, 2021
@kitsonk kitsonk deleted the kitsonk/issue10194 branch June 1, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: panic with multi-cursor editing within import urls Registry auto discovery in LSP
2 participants
@kitsonk @lucacasonato