Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make 'deno lint' stable #10851

Merged
merged 1 commit into from Jun 5, 2021
Merged

feat: make 'deno lint' stable #10851

merged 1 commit into from Jun 5, 2021

Conversation

bartlomieju
Copy link
Member

We've discussed this several times, and 1.11 is high time to stabilize linter.

lucacasonato
lucacasonato approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I think there is precedent that rules can change on a stable linter (see clippy), so I think this distinction was pretty arbitrary anyway.

@bartlomieju
Copy link
Member Author

SGTM. I think there is precedent that rules can change on a stable linter (see clippy), so I think this distinction was pretty arbitrary anyway.

Agreed, and some users were discouraged from using linter because it was "unstable".

@bartlomieju bartlomieju merged commit 1d070f3 into denoland:main Jun 5, 2021
@bartlomieju bartlomieju deleted the stable_linter branch June 5, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @lucacasonato