fix(runtime): early binding to dispatchEvent in workers #10904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't checked if this is covered by the WPT, so I added an integration test. Ref #10903. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working with workers and realised that if your overwrite
dispatchEventin the global scope, messages do not get sent to event listeners of"message"any longer. This is because the runtime binds to the globaldispatchEventevery time it tries to dispatch a message.I checked that in browsers, if you override
dispatchEventin a worker, messages still get sent to the event listeners, and so I have amended the runtime to bind early to the globaldispatchEventand this ensures the behaviour works as expected.