Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): improve worker types #10965

Merged
merged 2 commits into from Jun 15, 2021
Merged

fix(cli): improve worker types #10965

merged 2 commits into from Jun 15, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jun 14, 2021

This fixes issues with the Deno built-in types that prevented the appropriate type checking of web workers when using addEventListener("message", /* ... */); plus a few other improvements to align it more to the TypeScript libs.

@kitsonk kitsonk requested a review from dsherret June 14, 2021 21:07
@kitsonk kitsonk requested a review from dsherret June 15, 2021 00:36
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 1eac527 into denoland:main Jun 15, 2021
@kitsonk kitsonk deleted the web-worker branch June 15, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants