fix: make WHATWG streams more compliant #10967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
Jun 15, 2021
| @@ -3475,7 +3635,11 @@ | |||
| * @param {R} chunk | |||
| * @returns {void} | |||
| */ | |||
| enqueue(chunk) { | |||
| enqueue(chunk = undefined) { | |||
There was a problem hiding this comment.
That is odd... is there a reason?
There was a problem hiding this comment.
Yup - prototype.enqueue.length will be wrong otherwise (1 instead of 0). Optional fields shouldn't count towards length, and this marks a field as optional in JS.
kitsonk
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lot of WPT tests, mainly by moving a lot of the custom validation logic to use converters from the deno_webidl crate. It also fixes various issue with how callbacks are handled and normalized.
There are still many, many failing tests, but I would rather land this as is to not inflate the diff on this PR even more.