Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inspector): Deno.inspect should inspect the object the proxy represents rather than the target #10977

Merged
merged 1 commit into from Jun 15, 2021
Merged

fix(inspector): Deno.inspect should inspect the object the proxy represents rather than the target #10977

merged 1 commit into from Jun 15, 2021

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 15, 2021 •
edited

I was so confused why proxies weren't working in the inspector when working on a different fix.

Closes #10975.

Note: Target is the first argument provided to the constructor of Proxy

bartlomieju
bartlomieju approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 984b8bf into denoland:main Jun 15, 2021
@dsherret dsherret deleted the inspect-proxy-not-target branch June 15, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspecting a proxy with showProxy: false incorrectly inspects the target
2 participants
@dsherret @bartlomieju