Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extensions/websocket): WPT conformance #11010

Merged
merged 14 commits into from
Jun 21, 2021
Merged

fix(extensions/websocket): WPT conformance #11010

merged 14 commits into from
Jun 21, 2021

Conversation

crowlKats
Copy link
Member

No description provided.

lucacasonato
lucacasonato reviewed Jun 17, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the requiredArguments function from 01_websocket.js, and just use webidl.requiredArguments

lucacasonato
lucacasonato reviewed Jun 17, 2021
View reviewed changes
extensions/websocket/01_websocket.js Outdated Show resolved Hide resolved
extensions/websocket/01_websocket.js Outdated Show resolved Hide resolved
lucacasonato
lucacasonato approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one final minor fix.

extensions/websocket/01_websocket.js Outdated Show resolved Hide resolved
@crowlKats @lucacasonato
Update extensions/websocket/01_websocket.js
a357352 
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
@lucacasonato lucacasonato merged commit afe89e8 into denoland:main Jun 21, 2021
@lucacasonato
Copy link
Member

Thanks!

@crowlKats crowlKats deleted the websocket_conformance branch June 21, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crowlKats @lucacasonato