Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use primordials in runtime/, part2 #11248

Merged
merged 6 commits into from
Jul 3, 2021
Merged

refactor: use primordials in runtime/, part2 #11248

merged 6 commits into from
Jul 3, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jul 3, 2021 •
edited

Ref #11224

@bartlomieju bartlomieju changed the title refactor: use primordials in runtime/, part1 refactor: use primordials in runtime/, part2 Jul 3, 2021
@bartlomieju bartlomieju mentioned this pull request Jul 3, 2021
Closed
67 tasks
SimonRask
SimonRask reviewed Jul 3, 2021
View reviewed changes
runtime/js/41_prompt.js Outdated Show resolved Hide resolved
SimonRask
SimonRask reviewed Jul 3, 2021
View reviewed changes
runtime/js/41_prompt.js Outdated Show resolved Hide resolved
@SimonRask
Copy link
Contributor

In 40_signals.js line 254, I think you can use PromisePrototypeThen
In 40_testing.js line 155, you can use ArrayPrototypePush

lucacasonato
lucacasonato approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 5addba2 into denoland:main Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRask SimonRask SimonRask left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @SimonRask @lucacasonato