refactor: use primordials for extensions/console #11249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Jul 5, 2021
Comment on lines
+629
to
+635
| return StringPrototypeReplace( | ||
| StringPrototypeReplace( | ||
| StringPrototypeReplace( | ||
| StringPrototypeReplace( | ||
| StringPrototypeReplace( | ||
| StringPrototypeReplace( | ||
| StringPrototypeReplace(string, /[\b]/g, "\\b"), |
There was a problem hiding this comment.
:( maybe use temp variable and reassign to it? It's hard to read
There was a problem hiding this comment.
This also generally looks like something in need of cleanup. Doing a full text scan 7 times doesn't seem very efficient...
There was a problem hiding this comment.
yeah that looks ugly though I did not want to change any functionality in this PR
There was a problem hiding this comment.
Good point. Let's do that in a follow up
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11224