Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use primordials in extensions/web/02_event.js #11264

Merged
merged 4 commits into from
Jul 4, 2021
Merged

refactor: use primordials in extensions/web/02_event.js #11264

merged 4 commits into from
Jul 4, 2021

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju mentioned this pull request Jul 4, 2021
Closed
67 tasks
satyarohith
satyarohith approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see the comment.

@SimonRask
Copy link
Contributor

WeakMapPrototypeGet on line 1014 I think :)

@bartlomieju bartlomieju merged commit f0fbd49 into denoland:main Jul 4, 2021
@bartlomieju bartlomieju deleted the primordials_event branch July 4, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @SimonRask @satyarohith