-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor use primordials in extensions/webgpu #11265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebGPU flies are huge. I should've checked the line count of the files before I started the review. 😄
Nice work, Bartek. I couldn't find a single instance unaddressed.
LGTM.
Found some things in
Found nothing in |
Thanks for taking a look, @SimonRask! |
There were a few accesses on TypedArray/DataView objects that aren't using primordials here, e.g. directly accessing the |
@crimsoncodes0 I believe this is the same situation as with |
String length are array length properties are safe to access, as that is the only way to access them. String have an immutable own property length, while arrays have a "magic" own property that has setting intercepted by the engine to cast the written value to an unsigned integer. TupedArray properties are very different, in that they aren't nearly as safe, nor are they own properties. If it would be appreciated, I can make some PRs tommorow to use them across the JavaScript. |
@crimsoncodes0 thanks explanation. Please do open a PR. |
#11224