Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Configure compiler with tsconfig.json #1136

Closed
wants to merge 4 commits into from

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Oct 31, 2018

Fixes #51

This PR add support for configuring the compiler via a tsconfig JSON via specified via the -c or --config command line arguments.

The tsconfig is read in and processed so that any options in the compilerOptions values that would interfere with Deno or are meaningless in a Deno context are ignored. A warning will be logged to the console indicating any ignored options.

Example of the flag usage and output:

$ ./out/debug/deno tests/002_hello.ts
Hello World
$ ./out/debug/deno tests/002_hello.ts --config tsconfig.json
Unsupported compiler options in: "tsconfig.json"
  The following options were ignored:
    baseUrl, module, moduleResolution, noLib, paths, pretty, types
Hello World
$ ./out/debug/deno tests/002_hello.ts --config bad.json
Specified configuration "bad.json" not found.

I think it is functionally complete but does not have all the tests.

@kitsonk
Copy link
Contributor Author

kitsonk commented Nov 5, 2018

@ry this is ready for review. Will squash once I have incorporated any feedback. I will also add some unit tests for the compiler.configure().

@kitsonk
Copy link
Contributor Author

kitsonk commented Jan 4, 2019

Closing for now, as this will need to be re-worked once the compiler infrastructure is refactored.

@kitsonk kitsonk closed this Jan 4, 2019
@kitsonk kitsonk deleted the tsconfig-resolve branch August 2, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant