Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): deno doc panics on invalid url #11536

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix(cli): deno doc panics on invalid url #11536

merged 1 commit into from
Jul 29, 2021

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Jul 27, 2021

fix #11529

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@F3n67u F3n67u force-pushed the fix/cli-docs branch 2 times, most recently from d1fcd60 to 70f3ab6 Compare July 27, 2021 15:40
bartlomieju
bartlomieju reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @F3n67u, please add a test exercising the fixed failure

cli/tools/doc.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 935083d into denoland:main Jul 29, 2021
@F3n67u F3n67u deleted the fix/cli-docs branch July 29, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: deno doc panics on invalid url
4 participants
@F3n67u @CLAassistant @ry @bartlomieju