Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(unstable): Rename Deno.WebSocketUpgrade::websocket to socket #11542

Merged
merged 1 commit into from
Jul 28, 2021
Merged

BREAKING(unstable): Rename Deno.WebSocketUpgrade::websocket to socket #11542

merged 1 commit into from
Jul 28, 2021

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Jul 28, 2021 •
edited

Closes #11400.

bartlomieju
bartlomieju approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit 42afbed into denoland:main Jul 28, 2021
@nayeemrmn nayeemrmn deleted the web-socket-upgrade-rename branch July 30, 2021 13:15
@rotu rotu mentioned this pull request Sep 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Deno.WebSocketUpgrade::websocket to socket
2 participants
@nayeemrmn @bartlomieju