feat(extensions/fetch): Add Origin header to outgoing requests for fetch #11557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F3n67u
force-pushed
the
fetch-origin-header
branch
4 times, most recently
from
0cb7110
to
5663b6c
Compare
F3n67u
force-pushed
the
fetch-origin-header
branch
from
5663b6c
to
1227be8
Compare
lucacasonato
reviewed
Aug 2, 2021
Comment on lines
+434
to
+444
| const baseURL = getLocationHref(); | ||
| if ( | ||
| baseURL && | ||
| (requestObject.method !== "GET" && requestObject.method !== "HEAD") | ||
| ) { | ||
| ArrayPrototypePush(request.headerList, [ | ||
| "origin", | ||
| new URL(baseURL).origin, | ||
| ]); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not correct. The header should be added of a different function in the implementation. The spec explains this.
The origin header should also respect request referrer policy.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, take a look at where it is called.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Aug 2, 2021
… for fetch (denoland#11557)" This reverts commit f87aa44.
Is there any use case where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10992