Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unstable): clean environmental variables for subprocess #11571

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

crowlKats
Copy link
Member

Closes #3981

@bartlomieju bartlomieju added this to the 1.13.0 milestone Aug 3, 2021
@ry
Copy link
Member

ry commented Aug 3, 2021

Why not Deno.env.clear() to stick with the Map-like interface?

I'm a little concerned that this is immediately going to stable. Is it possible to make this unstable first?

@bartlomieju
Copy link
Member

Why not Deno.env.clear() to stick with the Map-like interface?

This is not API for Deno.env, it's an option when starting a subprocess with Deno.run(). But I agree with @bnoordhuis suggestion that it might be better to name it clearEnv

@crowlKats
Copy link
Member Author

crowlKats commented Aug 3, 2021

Is it possible to make this unstable first?

sure, i am quite in favour of that.

@bartlomieju bartlomieju changed the title feat(runtime): clean environmental variables for subprocess feat(unstable): clean environmental variables for subprocess Aug 4, 2021
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @crowlKats!

@bartlomieju bartlomieju merged commit 2ac031d into denoland:main Aug 4, 2021
@crowlKats crowlKats deleted the run_clean_env branch August 5, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.run clean environment
3 participants