Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket): allow any close code for server #11614

Merged
merged 1 commit into from
Aug 9, 2021
Merged

fix(websocket): allow any close code for server #11614

merged 1 commit into from
Aug 9, 2021

Conversation

crowlKats
Copy link
Member

Fixes #11611

@bartlomieju
Copy link
Member

Can we get a test please?

@crowlKats
Copy link
Member Author

crowlKats commented Aug 9, 2021 •
edited

Can we get a test please?

There already is: i modified existing test to use an "invalid" code. but if needed, sure i can make a separate one

@bartlomieju
Copy link
Member

Can we get a test please?

There already is: i modified existing test to use an invalid code. but if needed, sure i can make a separate one

Oooops, you're right

bartlomieju
bartlomieju approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit f546f51 into denoland:main Aug 9, 2021
@crowlKats crowlKats deleted the websocket_server_close_any branch August 9, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native websockets: allow WebSocket.close to be called with codes from 1000 through 3000
2 participants
@crowlKats @bartlomieju