Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: network panel support for DevTools #11660

Closed
wants to merge 7 commits into from

Conversation

lucacasonato
Copy link
Member

Let's get fetch and WebSocket hooked up to the "Network" panel in Chrome DevTools.

let inspector = js_runtime.inspector();
let session_sender = inspector.get_session_sender();
let deregister_rx = inspector.add_deregister_handler();
server.register_inspector(
session_sender,
deregister_rx,
main_module.to_string(),
dev_tools_agent,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So unless I missed something we end up the minor caveat here that local sessions won't support the same extended subset as remote sessions get? maybe it'd be better to make the agent own the inspector?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a prototype that will be rewritten. I guess you're still referring to the ability to connect local REPL session to the Devtools?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a prototype that will be rewritten. I guess you're still referring to the ability to connect local REPL session to the Devtools?

Yeah it's low hanging fruit but hypothetically we'd want to expose the local inspector as as a cli binding ala node down the line.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2021

CLA assistant check
All committers have signed the CLA.

@piscisaureus piscisaureus self-requested a review December 9, 2021 17:39
@bartlomieju
Copy link
Member

Stale, closing for now, I'll try to revisit this feature in Q1 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants