Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): enable non-extractable keys #11705

Merged
merged 5 commits into from
Aug 16, 2021
Merged

fix(ext/crypto): enable non-extractable keys #11705

merged 5 commits into from
Aug 16, 2021

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Aug 14, 2021 •
edited

Closes #11481

Towards #11690

@littledivy littledivy marked this pull request as draft August 14, 2021 12:47
@littledivy littledivy marked this pull request as ready for review August 14, 2021 13:19
@lucacasonato lucacasonato changed the title chore(ext/crypto): Enable extractable keys fix(ext/crypto): enable non-extractable keys Aug 14, 2021
lucacasonato
lucacasonato approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very awesome. So many more passing tests 🎉

Thanks @littledivy!

@lucacasonato lucacasonato merged commit eea6f57 into denoland:main Aug 16, 2021
@littledivy littledivy deleted the enable-extractable branch August 16, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable non-extractable keys for Web Crypto
3 participants
@littledivy @panva @lucacasonato