chore: upgrade dlint and run prefer-primordials
#11777
Conversation
| "exclude": [ | ||
| "no-invalid-triple-slash-reference" | ||
| ] |
There was a problem hiding this comment.
If I understand correctly, no-invalid-triple-slash-reference rule is for Deno users, not for the internal code of Deno, so I added it here. Please correct me if I'm wrong.
https://lint.deno.land/#no-invalid-triple-slash-reference
| // deno-lint-ignore prefer-primordials | ||
| Error.prepareStackTrace = prepareStackTrace; |
There was a problem hiding this comment.
In Node.js, Error.prepareStackTrace is skipped linting because of the config. But deno_lint doesn't support it right now, so just added an ignore directive here for the moment.
| async function dlintPreferPrimordials() { | ||
| const execPath = getPrebuiltToolPath("dlint"); | ||
| console.log("prefer-primordials"); | ||
|
|
||
| const sourceFiles = await getSources(ROOT_PATH, [ | ||
| "runtime/**/*.js", | ||
| "ext/**/*.js", | ||
| "core/**/*.js", | ||
| ":!:core/examples/**", | ||
| ]); | ||
|
|
||
| if (!sourceFiles.length) { | ||
| return; | ||
| } | ||
|
|
||
| const chunks = splitToChunks(sourceFiles, `${execPath} run`.length); | ||
| for (const chunk of chunks) { | ||
| const p = Deno.run({ | ||
| cmd: [execPath, "run", "--rule", "prefer-primordials", ...chunk], | ||
| }); | ||
| const { success } = await p.status(); | ||
| if (!success) { | ||
| throw new Error("prefer-primordials failed"); | ||
| } | ||
| p.close(); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think prefer-primordials should apply only to the code related to bootstrapping, so I created another function where only this rule is run.
There was a problem hiding this comment.
Makes sense, please add a comment explaining that
magurotuna
force-pushed
the
upgrade-dlint
branch
from
d4f6888
to
0cf3bfb
Compare
This PR upgrades
third_partysubmodule to the latest to get dlint 0.12.0, and appliesprefer-primordialsto the files under runtime, ext, and core.