Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/http): resource leak on HttpConn.close() #11805

Merged
merged 5 commits into from
Aug 23, 2021
Merged

fix(ext/http): resource leak on HttpConn.close() #11805

merged 5 commits into from
Aug 23, 2021

Conversation

bartlomieju
Copy link
Member

Closes #11743

This is implemented in JavaScript, because we don't have necessary infrastructure
in Rust.

lucacasonato
lucacasonato reviewed Aug 23, 2021
View reviewed changes
ext/http/01_http.js Outdated Show resolved Hide resolved
@bartlomieju bartlomieju merged commit 2187c11 into denoland:main Aug 23, 2021
@bartlomieju bartlomieju deleted the fix_resource_leak_in_http branch August 23, 2021 14:16
@cmorten cmorten mentioned this pull request Aug 24, 2021
Merged
@bartlomieju bartlomieju mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ext/http]: responseSender open resource handle after connection and listener close
2 participants
@bartlomieju @lucacasonato