Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add URLPattern API #11941

Merged
merged 10 commits into from
Sep 8, 2021
Merged

feat: add URLPattern API #11941

merged 10 commits into from
Sep 8, 2021

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Sep 7, 2021

This adds support for the URLPattern API.

The API is added in --unstable only, as it has not yet shipped in any
browser. It is targeted for shipping in Chrome 95.

Spec: https://wicg.github.io/urlpattern/

Closes #11619


TODOs:

  • Add JSDoc comments to lib.deno_url.d.ts
  • Add a TypeScript unit test to validate typings.

This adds support for the URLPattern  API.

The API is added in --unstable only, as it has not yet shipped in any
browser. It is targeted for shipping in Chrome 95.

Spec: https://wicg.github.io/urlpattern/
@lucacasonato
Copy link
Member Author

lucacasonato commented Sep 7, 2021

The final failing test is denoland/rust-urlpattern#12. We are waiting on a spec decision. This can be landed as is though.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus one typo. I don't see this PR doing any hackery with serde_v8 you mentioned; has this been worked around in some way?

ext/url/README.md Outdated Show resolved Hide resolved
@crowlKats
Copy link
Member

crowlKats commented Sep 8, 2021

LGTM, minus one typo. I don't see this PR doing any hackery with serde_v8 you mentioned; has this been worked around in some way?

Yes, this isnt addressed yet, but we can work around it using the regress crate instead of the normal regex one

@bartlomieju
Copy link
Member

LGTM, minus one typo. I don't see this PR doing any hackery with serde_v8 you mentioned; has this been worked around in some way?

Yes, this isnt addressed yet, but we can work around it using the regress crate instead of the normal regex one

Sounds good, thanks for explanation.

@lucacasonato lucacasonato merged commit e07f28d into denoland:main Sep 8, 2021
@lucacasonato lucacasonato deleted the urlpattern branch September 8, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Add URLPattern global
4 participants