-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add URLPattern API #11941
feat: add URLPattern API #11941
Conversation
This adds support for the URLPattern API. The API is added in --unstable only, as it has not yet shipped in any browser. It is targeted for shipping in Chrome 95. Spec: https://wicg.github.io/urlpattern/
The final failing test is denoland/rust-urlpattern#12. We are waiting on a spec decision. This can be landed as is though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minus one typo. I don't see this PR doing any hackery with serde_v8
you mentioned; has this been worked around in some way?
Yes, this isnt addressed yet, but we can work around it using the |
Sounds good, thanks for explanation. |
This adds support for the URLPattern API.
The API is added in --unstable only, as it has not yet shipped in any
browser. It is targeted for shipping in Chrome 95.
Spec: https://wicg.github.io/urlpattern/
Closes #11619
TODOs: