fix(lsp): align filter text to vscode logic #12081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Sep 15, 2021
| if let Some(insert_text) = &self.insert_text { | ||
| if insert_text.starts_with("this.#") { | ||
| return Some(insert_text.replace("this.#", "")); | ||
| } else { |
There was a problem hiding this comment.
Do we need to remove this. in the case where it only starts with this.?
There was a problem hiding this comment.
It is a replication of the vscode logic, which does not do this. And it only sets the filter text. When the replacement text is this.# there is then effectively empty filter text, which is then nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11861