fix(http): panic when responding to a closed conn #12216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our oneshot receiver in `HyperService::call` would unwrap and panic, the `.await` on the oneshot receiver happens when the sender is dropped. The sender is dropped in `op_http_response` because: 1. We take `ResponseSenderResource` 2. Then get `ConnResource` and early exit on failure (conn already closed) 3. The taken sender then gets dropped in this early exit before any response is sent over the channel Fallbacking to returning a dummy response to hyper seems to be a fine quickfix
|
Fix LGTM, is it possible to add a test for this? A stand-alone test is here: https://github.com/denoland/deploy/issues/1949#issuecomment-926873141 |
piscisaureus
approved these changes
Sep 25, 2021
ry
requested changes
Sep 25, 2021
I've added a non-flaky test. You can run it yourself: |
must have non-empty catch branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our oneshot receiver in
HyperService::callwould unwrap and panic, the.awaiton the oneshot receiver errors when the sender is dropped.The sender is dropped in
op_http_responsebecause:ResponseSenderResource(which owns the sender)op_http_responsedue to the conn being closedFallbacking to returning a dummy response to hyper seems to be a fine quickfix