fix: --no-check not properly handling code nested in TS expressions #12416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a quick resolution. Is this a candidate for a quick 1.15.1? |
|
@panva 1.15.1 coming up in about 50 minutes. |
|
It seems Deno v1.15.1 is not released yet (5 hours passed from previous comment). It seems CI fails and stack? |
|
@lambdalisue Yeah GitHub Actions is having some issues. We are about 95% there now. Give us a couple more minutes. |
|
Understand. Thanks for Deno teams great work 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that a
resolver_with_markwas used since that's what the documentation said to use, but because we're using TypeScript we should have used ats_resolverinstead.Closes #12409, #12413