-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/ffi): support null
in buffer argument
#12823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DjDeveloperr tentatively this looks good to me, but please update type declarations to reflect that if buffer is null
then buffer length shouldn't be passed as the next argument. Also an update to manual would be appreciated too.
Do I add that to type declarations of |
I guess you don't need to add any types to |
@bartlomieju Added an example for buffer argument and some notes about null buffer argument in JS doc. |
Looks like #12828 adds this too.. I guess I'll close this. |
null
in buffer argument. Corresponds tonullptr
in FFI.Fixes #12809