Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): properly generate data URLs for completion items #13246

Merged
merged 1 commit into from
Jan 2, 2022
Merged

fix(lsp): properly generate data URLs for completion items #13246

merged 1 commit into from
Jan 2, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 31, 2021

Discovered an issue with registry completions when generating the documentation URLs where matched variables needed to be interpolated.

bartlomieju
bartlomieju approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 0ae46a9 into denoland:main Jan 2, 2022
@kitsonk kitsonk deleted the fix_doc_data branch January 2, 2022 05:25
bartlomieju pushed a commit that referenced this pull request Jan 5, 2022
@kitsonk @bartlomieju
fix(lsp): properly generate data URLs for completion items (#13246)
74ed687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kitsonk @bartlomieju