feat(cli): add --no-clear-screen flag
#13454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
Jan 21, 2022
|
Added one integration test |
bartlomieju
reviewed
Jan 23, 2022
cli/flags.rs
Outdated
| @@ -1768,6 +1781,8 @@ fn bundle_parse(flags: &mut Flags, matches: &clap::ArgMatches) { | |||
|
|
|||
| watch_arg_parse(flags, matches, false); | |||
|
|
|||
| no_clear_screen_arg_parse(flags, matches); | |||
There was a problem hiding this comment.
Maybe merge this function with watch_arg_parse?
Comment on lines
+4525
to
+4518
| #[test] | ||
| fn test_watch_with_no_clear_screen() { |
There was a problem hiding this comment.
Looks good 👍 please add a test case that uses --no-clear-screen but doesn't use --watch and assert that it returns error
cli/main.rs
Outdated
|
|
||
| tools::lint::lint(maybe_lint_config, lint_flags, flags.watch.is_some()) | ||
| .await?; | ||
| tools::lint::lint(lint_flags, flags).await?; |
There was a problem hiding this comment.
Please flip order of the arguments (flags, lint_flags)
cli/tools/lint.rs
Outdated
| lint_flags: LintFlags, | ||
| watch: bool, | ||
| ) -> Result<(), AnyError> { | ||
| pub async fn lint(lint_flags: LintFlags, flags: Flags) -> Result<(), AnyError> { |
|
@bartlomieju Update |
ah-yu
requested review from
bnoordhuis,
kitsonk,
kt3k,
littledivy,
lucacasonato and
piscisaureus
as code owners
ah-yu
force-pushed
the
feat/watch
branch
2 times, most recently
from
9a58145
to
5705384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13315