fix(lsp): regression where certain diagnostics were showing for disabled files #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 29, 2022
| .unwrap_or_default(); | ||
| let diagnostics = generate_ts_diagnostics( | ||
| snapshot.clone(), | ||
| &config, |
There was a problem hiding this comment.
I had intended to flip diagnostics to not be calculated at all upfront if the config was disabled and then I completely forgot to do the second half of that 🤦♂️
| .cloned() | ||
| .partition::<Vec<_>, _>(|s| config.specifier_enabled(s)); | ||
| let ts_diagnostics_map: TsDiagnosticsMap = if !enabled_specifiers.is_empty() { | ||
| let req = tsc::RequestMethod::GetDiagnostics(enabled_specifiers); |
There was a problem hiding this comment.
I think only doing this for enabled specifiers should be a decent performance improvement in workspaces with a lot of disabled files.
ry
pushed a commit
to ry/deno
that referenced
this pull request
Feb 3, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13524