Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): support EC p256 private key material in exportKey #13547

Merged
merged 4 commits into from
Feb 8, 2022
Merged

fix(ext/crypto): support EC p256 private key material in exportKey #13547

merged 4 commits into from
Feb 8, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jan 31, 2022 •
edited

Fixes #13549

@littledivy littledivy marked this pull request as ready for review January 31, 2022 04:53
cryptographix
cryptographix reviewed Feb 2, 2022
View reviewed changes
ext/crypto/shared.rs Outdated Show resolved Hide resolved
@littledivy
Copy link
Member Author

littledivy commented Feb 8, 2022 •
edited

Thanks for completing this @lucacasonato

@littledivy littledivy merged commit e218d56 into denoland:main Feb 8, 2022
@littledivy littledivy deleted the ec_private_conversion branch February 8, 2022 13:18
@cryptographix
Copy link
Contributor

@littledivy maybe should rename issue and merge to include P384?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptographix cryptographix cryptographix left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spki CryptoKey export not working for ECDSA
3 participants
@littledivy @cryptographix @lucacasonato