Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): do not panic getting root_uri to auto discover configuration file #13603

Merged
merged 2 commits into from
Feb 5, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 5, 2022

I haven't been able to reproduce this scenario in order to write a test, but this should help give us better information for the error message and probably not fail.

Closes #13601

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thought

cli/lsp/language_server.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread 'main' panicked at 'called Result::unwrap() on an Err value: ()', cli\lsp\language_server.rs:341:47
2 participants