Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Deno.FsFile, deprecate Deno.File #13660

Merged
merged 2 commits into from
Feb 15, 2022
Merged

feat: Add Deno.FsFile, deprecate Deno.File #13660

merged 2 commits into from
Feb 15, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 13, 2022 •
edited

Still need to update deno lint to warn about deprecated Deno.File.

Closes #13661

This was referenced Feb 13, 2022
Merged
Merged
dsherret
dsherret approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucacasonato
lucacasonato approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 9b5e336 into denoland:main Feb 15, 2022
@bartlomieju bartlomieju deleted the rename_deno_file branch February 15, 2022 12:59
@kt3k kt3k mentioned this pull request Feb 25, 2022
Merged
@maplecfiv maplecfiv mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@dsherret dsherret dsherret approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Deno.File to Deno.FsFile
4 participants
@bartlomieju @kt3k @dsherret @lucacasonato