BREAKING: don't inherit permissions by default #13668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously specifying permissions: {} was the same as specifying
permissions: "inherit". Now it will be the same as permissions: "none".
Not specifying any permissions (permissions: undefined) still means
permissions: "inherit".
This is a breaking change. I want to try land this soon, as the current
behaviour is really impractical. If this can not be changed right now, I
am proposing it as a 2.0 change.
|
Completely in favour of this change. But this is massively breaking, we should hold on for it to 2.0 |
|
I'm also in favor of this change but even though it's breaking I think we should ship it in 1.20. This behavior is less surprising and if some user hits the problem with it I think they will appreciate the soundness of new behavior. |
|
I'm in favour of doing it for 1.20. Yes, it is a breaking change, but one could argue it is a security issue, which if it breaks some people doing things that are unsafe, we have helped them. |
|
Why exactly did we land this with no tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously specifying permissions: {} was the same as specifying
permissions: "inherit". Now it will be the same as permissions: "none".
Not specifying any permissions (permissions: undefined) still means
permissions: "inherit".
This is a breaking change. I want to try land this soon, as the current
behaviour is really impractical. If this can not be changed right now, I
am proposing it as a 2.0 change.