feat(test): improved op sanitizer errors + traces #13676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Feb 15, 2022
ry
reviewed
Feb 15, 2022
ry
reviewed
Feb 15, 2022
| * To get high level metrics on async ops with no added performance cost, | ||
| * use `Deno.core.metrics()`. | ||
| */ | ||
| function enableOpCallTracing(): void; |
There was a problem hiding this comment.
why not just have a boolean value that can be assigned, rather than a function:
Deno.core.enableOpCallTracing = true;
This allows for future flexibility (if you want to turn it off) and less wrapper.
There was a problem hiding this comment.
The chosen approach is actually intentional: the "enabled" flag is a boolean (a primitive), so assigning it to Deno.core assigns it by value, not by reference. To fix this, we'd need to change the check in opAsync to be if (core.opCallTracingEnabled) instead of if (opCallTracingEnabled). The former introduces an additional property lookup to all opAsync calls which I don't really want as it is a super hot path.
ry
approved these changes
Feb 15, 2022
lucacasonato
force-pushed
the
improved_resource_test
branch
2 times, most recently
from
b515bcb
to
1cb2ec9
Compare
lucacasonato
force-pushed
the
improved_resource_test
branch
from
1ed2608
to
1cb2ec9
Compare
This commit improves the error messages for the `deno test` async op sanitizer. It does this in two ways: - it uses handwritten error messages for each op that could be leaking - it includes traces showing where each op was started This "async op tracing" functionality is a new feature in deno_core. It likely has a significant performance impact, which is why it is only enabled in tests.
lucacasonato
force-pushed
the
improved_resource_test
branch
from
1cb2ec9
to
06b9289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the error messages for the
deno testasync opsanitizer. It does this in two ways:
This "async op tracing" functionality is a new feature in deno_core.
It likely has a significant performance impact, which is why it is only
enabled in tests.