feat: Add hint to permission prompt to display allow flag #13695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
previously requested changes
Feb 16, 2022
bartlomieju
changed the title
dsherret
approved these changes
Feb 16, 2022
| @@ -2197,9 +2197,9 @@ mod permissions { | |||
| let args = "run --quiet 061_permissions_request.ts"; | |||
| use util::PtyData::*; | |||
| util::test_pty2(args, vec![ | |||
| Output("⚠️ ️Deno requests read access to \"foo\". Allow? [y/n (y = yes allow, n = no deny)] "), | |||
| Output("⚠️ ️Deno requests read access to \"foo\". Run again with --allow-read to bypass this prompt.\r\n Allow? [y/n (y = yes allow, n = no deny)] "), | |||
There was a problem hiding this comment.
I don't understand why some of these have a trailing space and others don't considering a trailing space was added to the output. I guess there's some trimming on the output being done in the comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.