Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): use tokio::sync::mpsc::unbounded_channel #13881

Merged
merged 2 commits into from Mar 9, 2022
Merged

refactor(test): use tokio::sync::mpsc::unbounded_channel #13881

merged 2 commits into from Mar 9, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 9, 2022 •
edited

Prompted by #13713 (comment)

@bartlomieju
Copy link
Member Author

@dsherret I have no idea if this is preferable to using sync channel. TIOLI

dsherret
dsherret approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's one less thread being blocked now that we've used spawn.

@bartlomieju bartlomieju merged commit 85cb6f2 into denoland:main Mar 9, 2022
@bartlomieju bartlomieju deleted the test_use_tokio_channel branch March 9, 2022 00:34
kt3k pushed a commit that referenced this pull request Mar 10, 2022
@bartlomieju @kt3k
refactor(test): use tokio::sync::mpsc::unbounded_channel (#13881)
38e5866 
This causes to block one less thread when running "deno test"
subcommand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @dsherret