fix(vendor): handle relative imports when mapped local folder name differs from remote's #14465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using deno vendor this weekend and found this bug.
In this case, the
npm:x
folders will be mapped tonpm_x
. So when../npm:test/file.js?test
is resolved it can't find the folder because it's looking for../npm_test
. See the tests for more details.Maybe this is an import map bug though and shouldn't be fixed in deno vendor? Also, perhaps there is a better way than this fix?