Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent tampering of Deno.exit #14665

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 19, 2022

This PR prevents Deno.exit to fail by tampering of dispatchEvent methods.

ref #14648

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@kt3k kt3k requested a review from cjihrig May 19, 2022 01:10
@kt3k kt3k requested a review from bartlomieju as a code owner May 19, 2022 01:10
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit e7c894e into main May 20, 2022
@kt3k kt3k deleted the fix/prevent-deno-exit-tampering branch May 20, 2022 02:57
kitsonk pushed a commit that referenced this pull request May 27, 2022
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants