Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): do not report transpiled files with no lines #14699

Merged
merged 2 commits into from
May 22, 2022

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 21, 2022

This commit omits files from the coverage report that have no lines of code to report coverage for.

Fixes: #14683

This commit omits files from the coverage report that have no
lines of code to report coverage for.

Fixes: denoland#14683
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig cjihrig merged commit d55444b into denoland:main May 22, 2022
@cjihrig cjihrig deleted the no-lines branch May 22, 2022 14:45
kitsonk pushed a commit that referenced this pull request May 27, 2022
This commit omits files from the coverage report that have no
lines of code to report coverage for.

Fixes: #14683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno coverage prints NaN% for files that only declare an interface
2 participants