Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: remove Intl.v8BreakIterator #14864

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jun 14, 2022

This is a non-standard API that is mostly replaced by Intl.Segmenter.

This is a non-standard API that is mostly replaced by Intl.Collator.
@@ -1,10 +1,13 @@
// Copyright 2018-2022 the Deno authors. All rights reserved. MIT license.
"use strict";

// Removes the `__proto__` for security reasons. This intentionally makes
// Deno non compliant with ECMA-262 Annex B.2.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Object.prototype._proto__ has been moved from Annex B in the current spec, it would be a good time to update the comments while we are at it.

@lucacasonato lucacasonato merged commit 5bde4c7 into denoland:main Jun 15, 2022
@lucacasonato lucacasonato deleted the remove_v8breakiterator branch June 15, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants