fix(repl): Accept tab when previous character is space #14898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Jun 19, 2022
There was a problem hiding this comment.
Seems like a great usability addition; is it possible to add a test for this feature?
@dsherret please take a look too
ry
reviewed
Jun 20, 2022
Comment on lines
+400
to
+401
| struct TabEventHandler; | ||
| impl ConditionalEventHandler for TabEventHandler { |
There was a problem hiding this comment.
Add a comment about the purpose of this
dsherret
reviewed
Jun 20, 2022
There was a problem hiding this comment.
Thanks for this @sigmaSd! There are some pty tests for the repl here: https://github.com/denoland/deno/blob/main/cli/tests/integration/repl_tests.rs -- Would you be able to check if it's possible to add one for this?
| ) -> Option<Cmd> { | ||
| debug_assert_eq!(*evt, Event::from(KeyEvent::from('\t'))); | ||
| if ctx.line().is_empty() | ||
| || ctx.line()[..ctx.pos()] |
There was a problem hiding this comment.
To save other reviewers time, ctx.pos() is indeed byte position https://docs.rs/rustyline/9.1.2/rustyline/struct.EventContext.html
|
I added a simple test, do you have some ideas to improve it? |
dsherret
changed the title
dsherret
approved these changes
Jun 20, 2022
aslilac
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a heuristic that allows tabbing, if the user hits tab and the previous character on the line is white space he's most likely asking for an actual tab not completion.
Python repl for example does this.
tab.mov