Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): should fail --check on parse error #14907

Merged
merged 2 commits into from Jun 18, 2022
Merged

fix(fmt): should fail --check on parse error #14907

merged 2 commits into from Jun 18, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 18, 2022 •
edited

lucacasonato
lucacasonato approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit f564497 into denoland:main Jun 18, 2022
@dsherret dsherret deleted the fix_fmt_parse_error branch June 18, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @lucacasonato