perf(ext/ffi): Optimize FFI Rust side type checks #14923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor optimisation to FFI parameters' Rust side type checking / extraction.
Main change is avoiding
ZeroCopyBuf
in pointer extraction, asZeroCopyBuf
extracts and carries unnecessary information like the length of the buffer being pointed to. For FFI pointers, we are only interested in the actual pointer and not at all in the length of the buffer.Additionally, double type checks are avoided by liberal application of
if let Ok(value) = v8::Local::<v8::SomeType>::try_from(value)
. This doesn't show particularly high impact but maybe there's still something.Relevant comparisons:
As can be seen, the BigInt types don't really change in a way that can be said to definitely have an effect. However, buffers are now measurably more performant.